This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Log message will be raw (no traceId or any other metadata which comming with logentries lib), if AndroidLogger.getInstance().setSendRawLogMessage(false) was set. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with logentries lib), if AndroidLogger.getInstance().setSendRawLogMessage(false) was set.
rwtaylorjr
reviewed
Feb 5, 2018
| @@ -342,8 +342,11 @@ public void run() { | |||
| } | |||
|
|
|||
| if (message != null) { | |||
| this.leClient.write(Utils.formatMessage(message.replace("\n", LINE_SEP_REPLACER), | |||
| logHostName, useHttpPost)); | |||
| if(sendRawLogMessage){ | |||
There was a problem hiding this comment.
Unless i'm missing something, the variable name seems to contradict the intent. If sendRawLogMessage is true, the raw log message along with other information (TraceID, DeviceID, Timestamp, etc...) will be written to the output. Where as if sendRawLogMessage is false, it just sends the message without any additional meta-data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you please accept this changes in order to send raw log messages. without any metadata